Another OpenMP fix. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohm314
approved these changes
Dec 21, 2021
7 tasks
This seems to be important because of compiling with -cuda now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 worked with the NVIDIA compilers, but not with GCC.
We don't currently use GCC for GPU offloading, but we do use OpenMP for host threading so it isn't a good idea to break GCC + OpenMP compilation.
This reverts #1 in favour of a simpler approach, where we drop the dynamic cache size setting functionality entirely when compiling with OpenMP. This can be refined later if needed.