Avoid function-local static variables. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And declare the namespace-global version available on the target device when compiling with OpenMP.
7 tasks
olupton
changed the title
2 tasks
pramodk
reviewed
Dec 21, 2021
kotsaloscv
approved these changes
Dec 21, 2021
olupton
added a commit
that referenced
this pull request
Dec 21, 2021
Merged
olupton
added a commit
that referenced
this pull request
Dec 21, 2021
* Revert "Avoid function-local static variables. (#1)" * Use static cache sizes if OpenMP or OpenACC is enabled with NVIDIA compilers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such function-local static variables are not supported by the NVIDIA HPC compilers with OpenMP offload.
Replace one such variable with (effectively) a namespace-global inline variable, but actually define this as a static template member so as not to require C++17 (for inline variables).
See also: https://forums.developer.nvidia.com/t/enabling-openmp-offload-breaks-openacc-code/196643