Added support for external events and the ability to cancel an awaited durable timer #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnatoliB
reviewed
Sep 3, 2020
...s/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psm1
Outdated
Show resolved
Hide resolved
AnatoliB
reviewed
Sep 4, 2020
...s/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psd1
Outdated
Show resolved
Hide resolved
AnatoliB
reviewed
Sep 4, 2020
...s/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psm1
Outdated
Show resolved
Hide resolved
AnatoliB
reviewed
Sep 4, 2020
...s/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psm1
Outdated
Show resolved
Hide resolved
AnatoliB
reviewed
Sep 4, 2020
AnatoliB
requested changes
Sep 4, 2020
Contributor
AnatoliB
left a comment
AnatoliB
left a comment
There was a problem hiding this comment.
Great job Michael, thank you. Please let me know if you want to address the feedback soon, or I will do it next week.
ghost
added
the
…s an alias for Wait-DurableTask
…ableExternalEvent cmdlets
…to run indefinitely
…urableClientFromModulePrivateData function
michaelpeng36
force-pushed
the
external-events
branch
from
aabc430 to
1016e51
Compare
AnatoliB
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Start-DurableExternalEventListener cmdlet, which listens for an external event to be raised indefinitely. If the NoWait flag is present, then it returns an external event task to be awaited with the Wait-DurableTask cmdlet.
Added Send-DurableExternalEvent cmdlet, which makes an HTTP POST request to send an external event (along with associated event data) to a given orchestration instance.
Added Stop-DurableTimerTask cmdlet. which marks a given durable timer task as canceled. Without this cmdlet, an orchestration will not complete until all timers created have expired.
Added unit tests for external events and an E2E test for all three cmdlets.