Added omitted unit test and moved checks for Durable Client into GetDurableClientFromModulePrivateData function

Author: michaelpeng36

src/Modules/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psd1

@@ -61,7 +61,7 @@ CmdletsToExport = @(
     'Invoke-ActivityFunction',
     'Push-OutputBinding',
     'Set-FunctionInvocationContext',
-    "Start-DurableExternalEventListener",
+    'Start-DurableExternalEventListener',
     'Start-DurableTimer',
     'Stop-DurableTimerTask',
     'Trace-PipelineObject',

src/Modules/Microsoft.Azure.Functions.PowerShellWorker/Microsoft.Azure.Functions.PowerShellWorker.psm1

@@ -8,7 +8,10 @@ Set-Alias -Name Wait-ActivityFunction -Value Wait-DurableTask
 
 function GetDurableClientFromModulePrivateData {
     $PrivateData = $PSCmdlet.MyInvocation.MyCommand.Module.PrivateData
-    if ($PrivateData) {
+    if ($PrivateData -eq $null -or $PrivateData['DurableClient'] -eq $null) {
+        throw "No binding of the type 'durableClient' was defined."
+    }
+    else {
         $PrivateData['DurableClient']
     }
 }
@@ -50,9 +53,6 @@ function Start-NewOrchestration {
 
     if ($null -eq $DurableClient) {
         $DurableClient = GetDurableClientFromModulePrivateData
-        if ($null -eq $DurableClient) {
-            throw "Cannot start an orchestration function. No binding of the type 'durableClient' was defined."
-        }
     }
 
     $InstanceId = (New-Guid).Guid
@@ -98,9 +98,6 @@ function New-OrchestrationCheckStatusResponse {
 
     if ($null -eq $DurableClient) {
         $DurableClient = GetDurableClientFromModulePrivateData
-        if ($null -eq $DurableClient) {
-            throw "Cannot create orchestration check status response. No binding of the type 'durableClient' was defined."
-        }
     }
 
     [uri]$requestUrl = $Request.Url
@@ -172,22 +169,15 @@ function Send-DurableExternalEvent {
         [object] $EventData,
 
 		[Parameter(
-            Position=3,
             ValueFromPipelineByPropertyName=$true)]
         [string] $TaskHubName,
 
         [Parameter(
-            Position=4,
             ValueFromPipelineByPropertyName=$true)]
         [string] $ConnectionName
     )
-
-    CheckIfDurableFunctionsEnabled
 
     $DurableClient = GetDurableClientFromModulePrivateData
-    if ($null -eq $DurableClient) {
-        throw "Cannot send an external event to an orchestration function. No binding of the type 'durableClient' was defined."
-    }
 
     $RequestUrl = GetRaiseEventUrl -DurableClient $DurableClient -InstanceId $InstanceId -EventName $EventName -TaskHubName $TaskHubName -ConnectionName $ConnectionName
 

test/Unit/Durable/DurableTaskHandlerTests.cs

@@ -161,7 +161,7 @@ public void WaitAny_OutputsEarliestCompletedTask_WhenAnyTaskCompleted(bool compl
         }
 
         [Theory]
-        // [InlineData(false, true)]
+        [InlineData(false, true)]
         [InlineData(true, false)]
         public void WaitAny_WaitsForStop_WhenAllTasksAreNotCompleted(bool completed, bool expectedWaitForStop)
         {