Fix bug with endpoint failover #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsadsam
approved these changes
Aug 5, 2025
zhiyuanliang-ms
added a commit
that referenced
this pull request
Aug 21, 2025
* Merge pull request #684 from Azure/zhiyuanliang/fix-test Fix activity source test bug * Fix bug with endpoint failover (#686) * update endpoint in do while * add test * in progress * update test, update logic to backoff using correct endpoint * make test more specific --------- Co-authored-by: AMER JUSUPOVIC <[email protected]> Co-authored-by: Amer Jusupovic <[email protected]> * Support comment in json key value (#685) * support jsonc * remove unused reference * use private static option * Add request tracing for Aspire usage (#687) * add request tracing for aspire component * update tag name * version bump 8.4.0 (#690) --------- Co-authored-by: AMER JUSUPOVIC <[email protected]> Co-authored-by: Amer Jusupovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #680
Currently, the provider doesn't backoff all replicas as expected.
Expected
If there are 2 or more endpoints (1 store endpoint and 1+ replicas) and a request to the first endpoint fails with an exception that the provider does not consider "failoverable" (requesting another endpoint will not solve the issue), all endpoints will be backed off with an exponential backoff factoring in 1 failed request. This means the initial backoff will be around the minimum backoff time of 30 seconds.
Actual
If there are 2 or more endpoints (1 store endpoint and 1+ replicas) and a request to the first endpoint fails with an exception that the provider does not consider "failoverable" (requesting another endpoint will not solve the issue), only the current endpoint will be backed off. The backoff is also incorrectly calculated to be longer than expected.