Support comment in json key value #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for JSON comments in Azure App Configuration key values by enabling comment parsing in the JSON key value adapter. The implementation allows both single-line (//) and multi-line (/* */) comments to be properly handled when processing JSON configuration values.
- Configures JSON parsing to skip comments during processing
- Adds comprehensive test coverage for various comment scenarios including edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| JsonKeyValueAdapter.cs | Adds JsonDocumentOptions with CommentHandling.Skip to enable comment support in JSON parsing |
| JsonContentTypeTests.cs | Adds comprehensive test cases covering mixed comment styles, edge cases, and invalid JSON scenarios |
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/JsonKeyValueAdapter.cs
Outdated
Show resolved
Hide resolved
rossgrambo
previously approved these changes
Jul 31, 2025
jimmyca15
approved these changes
Aug 4, 2025
jimmyca15
reviewed
Aug 4, 2025
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/JsonKeyValueAdapter.cs
Outdated
Show resolved
Hide resolved
jimmyca15
previously approved these changes
Aug 4, 2025
zhiyuanliang-ms
dismissed stale reviews from jimmyca15 and rossgrambo
via
eb86aea
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/support-jsonc
branch
from
eb86aea to
5ab8381
Compare
samsadsam
approved these changes
Aug 5, 2025
jimmyca15
approved these changes
Aug 5, 2025
zhiyuanliang-ms
added a commit
that referenced
this pull request
Aug 21, 2025
* Merge pull request #684 from Azure/zhiyuanliang/fix-test Fix activity source test bug * Fix bug with endpoint failover (#686) * update endpoint in do while * add test * in progress * update test, update logic to backoff using correct endpoint * make test more specific --------- Co-authored-by: AMER JUSUPOVIC <[email protected]> Co-authored-by: Amer Jusupovic <[email protected]> * Support comment in json key value (#685) * support jsonc * remove unused reference * use private static option * Add request tracing for Aspire usage (#687) * add request tracing for aspire component * update tag name * version bump 8.4.0 (#690) --------- Co-authored-by: AMER JUSUPOVIC <[email protected]> Co-authored-by: Amer Jusupovic <[email protected]>
This was referenced Sep 20, 2025
This was referenced Sep 29, 2025
Closed
Open
This was referenced Oct 1, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Bump Microsoft.Azure.AppConfiguration.AspNetCore from 8.0.0 to 8.4.0
KranthiGajjelli/eshoponweb22#11
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
#671