Skip to content

Stop using React.Key in typings #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
Merged

Stop using React.Key in typings #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ declare module 'react-base-table' {
/**
* Unique key for each column
*/
key: React.Key;
key: string | number;
/**
* Class name for the column cell
*/
Expand Down Expand Up @@ -385,7 +385,7 @@ declare module 'react-base-table' {
* The sort state for the table, will be ignored if `sortState` is set
*/
sortBy?: {
key: React.Key;
key: string | number;
order: SortOrder;
};
/**
Expand All @@ -400,13 +400,13 @@ declare module 'react-base-table' {
* ```
*/
sortState?: {
[key in React.Key]: SortOrder;
[key in string | number]: SortOrder;
};
/**
* A callback function for the header cell click event
* The handler is of the shape of `({ column, key, order }) => *`
*/
onColumnSort?: (args: { column: ColumnShape<T>; key: React.Key; order: SortOrder }) => void;
onColumnSort?: (args: { column: ColumnShape<T>; key: string | number; order: SortOrder }) => void;
/**
* A callback function when resizing the column width
* The handler is of the shape of `({ column, width }) => *`
Expand Down