Stop using React.Key in typings #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typing for React.key has been changed to include 'bigint' (DefinitelyTyped/DefinitelyTyped#66723). React Team recommends not using this type for our own keys (specifically for object indexing types - see DefinitelyTyped/DefinitelyTyped#66749 (comment)). Attempting to use it as we do (specifically in `sortState`) causes an error when using @types/react@18, since typescript doesn't allow bigint as index type. Though this library doesn't officially support React 18, hardcoding the old type of string | number will at least prevent consumers' typechecking from breaking if they do use React 18.
steven-qi
approved these changes
May 24, 2024
tonnyskk
approved these changes
May 24, 2024
jc99ta
pushed a commit
to jc99ta/react-base-table
that referenced
this pull request
May 29, 2024
The typing for React.key has been changed to include 'bigint' (DefinitelyTyped/DefinitelyTyped#66723). React Team recommends not using this type for our own keys (specifically for object indexing types - see DefinitelyTyped/DefinitelyTyped#66749 (comment)). Attempting to use it as we do (specifically in `sortState`) causes an error when using @types/react@18, since typescript doesn't allow bigint as index type. Though this library doesn't officially support React 18, hardcoding the old type of string | number will at least prevent consumers' typechecking from breaking if they do use React 18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typing for React.key has been changed to include 'bigint' (DefinitelyTyped/DefinitelyTyped#66723). React Team recommends not using this type for our own keys (specifically for object indexing types - see DefinitelyTyped/DefinitelyTyped#66749 (comment)). Attempting to use it as we do (specifically in
sortState) causes an error when using @types/react@18, since typescript doesn't allow bigint as index type. Though this library doesn't officially support React 18, hardcoding the old type of string | number will at least prevent consumers' typechecking from breaking if they do use React 18.