Skip to content

Conversation

@mymindstorm
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #646 (c80794a) into release (243cfc2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head c80794a differs from pull request most recent head fcf3d89. Consider uploading reports for the commit fcf3d89 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           release     #646      +/-   ##
===========================================
- Coverage    15.15%   15.14%   -0.02%     
===========================================
  Files           15       15              
  Lines         1452     1453       +1     
  Branches       317      318       +1     
===========================================
  Hits           220      220              
- Misses        1214     1215       +1     
  Partials        18       18              
Impacted Files Coverage Δ
src/models/backup.ts 5.27% <0.00%> (-0.02%) ⬇️
src/store/Backup.ts 18.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243cfc2...fcf3d89. Read the comment docs.

@mymindstorm
Copy link
Member Author

@Sneezry is the FOSSA check supposed to be there? I don't have enough access to view what it is complaining about.

@Sneezry
Copy link
Member

Sneezry commented Apr 20, 2021

It's vuejs. Because we publish the project under MIT license, but FOSSA reports vuejs doesn't match MIT. It has one dependency published under GPL (src/compiler/parser/html-parser.js): https://app.fossa.com/projects/git%2Bgithub.202132.xyz%2FAuthenticator-Extension%2FAuthenticator/refs/branch/dev/c80794a6246b6155476d24c7dfd9ded5a3b2339c/preview

@Sneezry
Copy link
Member

Sneezry commented Apr 20, 2021

I have double checked, the impacted dependency is published by using multiple licenses. Apache-2.0 is included, so, it's MIT compatible. I have marked the issue resolved.

@mymindstorm mymindstorm merged commit a893dc5 into release Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants