Support for OneDrive Business #638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial work on an attempt to support OneDrive Business
Codecov Report
@@ Coverage Diff @@
## dev #638 +/- ##
==========================================
- Coverage 15.15% 14.36% -0.79%
==========================================
Files 15 15
Lines 1452 1573 +121
Branches 317 341 +24
==========================================
+ Hits 220 226 +6
- Misses 1214 1329 +115
Partials 18 18
Continue to review full report at Codecov.
|
|
Closing in favor of #641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #633 : OneDrive is stuck on 'account loading...' and does not work properly for professional accounts.
I noticed that you just added a new comment with a different approach, but this is what I had now and which seems to be working: it adds a separate page for OneDrive Business.
Only thing to consider: use the "common" string in the authorization URL; or go for "organizations" or even offer the option for a tenant ID. For now (and to avoid potential conflicts with OneDrive personal), I just went with "common".
This work might still help you for the working version :)