Deserialization of bccm payment method

[gcatanese]

The deserialization of a BCMC payment method fails with Failed deserialization for CheckoutPaymentMethod: 2 classes match result, expected 1 at 'paymentMethod'.

The root cause is in the custom deserializer inside CheckoutPaymentMethod. The logic it uses to match the type is too lenient, using contains() rather than stricter equals().

This PR updates the CheckoutPaymentMethod deserializer, adding tests to confirm the desired behaviour.

Note: the mustache templates will be updated in a separate PR (to update all deserializers in the library)

Fix #1531

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed a deserialization bug in the CheckoutPaymentMethod class where the contains() method was too lenient, causing issues with payment methods like BCMC. My fix replaces contains() with equals() for precise type matching, ensuring correct deserialization. I've also added comprehensive tests to validate this behavior.

Highlights

• Improved Payment Method Deserialization: I've updated the CheckoutPaymentMethod deserializer to use equals() instead of contains() for type matching, resolving a bug that caused incorrect deserialization for certain payment methods, such as BCMC.
• Enhanced Test Coverage: I've added new unit tests specifically for BCMC and BCMC Mobile payment methods to confirm the fix and prevent future regressions in deserialization logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a deserialization issue in CheckoutPaymentMethod by switching from String.contains() to String.equals() for type matching. This prevents incorrect deserialization when one payment method type string is a substring of another, as was the case for 'bcmc' and 'bcmc_mobile'. The addition of new tests in CheckoutTest and ModelTest effectively covers this fix.

My main feedback is regarding the significant code duplication in CheckoutPaymentMethod.deserialize(). While the fix is correct, the method's structure is difficult to maintain. I've suggested a more scalable, map-based approach that could be implemented when updating the generator templates. I also noted a minor issue in the new tests where an unused local variable can be removed.