-
Notifications
You must be signed in to change notification settings - Fork 146
Implement stricter oneOf deserialization #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request contains automatically generated code updates for Adyen's ACS webhooks and Balance Platform services. The changes reflect modifications in the OpenAPI specifications, ensuring the client libraries remain synchronized with the latest API definitions. The most significant change involves an improvement in the deserialization of polymorphic bank account identification types, enhancing the robustness of data handling. Other changes are primarily cosmetic, focusing on code style and formatting consistency across the generated models and services.
Highlights
- Automated Code Generation Update: The pull request primarily updates generated Java code for Adyen's ACS webhooks and Balance Platform APIs. This is a routine update reflecting changes in the underlying OpenAPI specifications.
- Improved Polymorphic Deserialization: The deserialization logic for
BankAccountAccountIdentificationwas updated to correctly handle polymorphic types based on thetypefield. This ensures accurate parsing of various bank account identification formats. - Code Style and Formatting Enhancements: Numerous minor code style and formatting adjustments were applied across many files, including reordering imports, simplifying Javadoc comments, and standardizing constructor declarations. These changes enhance code readability and maintainability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains a large number of changes across many files, which appear to be the result of an automated code generation process based on updated OpenAPI specifications. The modifications primarily consist of formatting improvements, such as standardized indentation, line breaks, and Javadoc comment styling. Additionally, there are minor but beneficial updates to the generated code, including more robust deserialization logic in some models.
After a thorough review, I have not identified any issues of medium or higher severity. The changes are consistent and appear to be safe improvements to the codebase. The pull request is ready for merging.
In the GitHub issue Deserialization of bccm payment method the deserialization code has been corrected to avoid failing with payment methods have similar names (i.e. bcmc , bcmc_mobile ).
This PR updates the Mustache templates to generate the expected deserialization code in all classes (where it is applicable)