Skip to content

CMake: Fix storage components paths #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2020
Merged

CMake: Fix storage components paths #13488

merged 2 commits into from
Aug 25, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 25, 2020

Summary of changes

The recent changes caused failing tests. I could reproduce locally, fixing SD component CMakelists.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 0xc0170 changed the base branch from master to feature-cmake August 25, 2020 11:36
@0xc0170 0xc0170 requested a review from hugueskamba August 25, 2020 11:36
@0xc0170 0xc0170 force-pushed the fix_cmake_sd_paths branch from 888affb to 7b3897a Compare August 25, 2020 11:37
@0xc0170 0xc0170 changed the title CMake: Fix cmake sd paths CMake: Fix SD paths Aug 25, 2020
@ciarmcom ciarmcom requested a review from a team August 25, 2020 12:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

hugueskamba
hugueskamba reviewed Aug 25, 2020
View reviewed changes
@0xc0170 0xc0170 force-pushed the fix_cmake_sd_paths branch from 7b3897a to dec0823 Compare August 25, 2020 12:47
@0xc0170 0xc0170 mentioned this pull request Aug 25, 2020
Merged
6 tasks
hugueskamba
hugueskamba previously requested changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and commit message to something like:

CMake: Fix blockdevice components source and include paths

This file paths were updated in master and this was broken after
rebasing.

@0xc0170
CMake: Fix blockdevice components source and include paths
9fa95ee 
This file paths were updated on master and this was broken after
rebasing.
@0xc0170 0xc0170 force-pushed the fix_cmake_sd_paths branch from d0a0c87 to 9fa95ee Compare August 25, 2020 14:21
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 25, 2020

Updated, all sources were updated and the commit mesage fixed as suggested.

@mergify mergify bot dismissed hugueskamba’s stale review August 25, 2020 14:21

Pull request has been modified.

@0xc0170 0xc0170 requested a review from hugueskamba August 25, 2020 14:22
@0xc0170 0xc0170 changed the title CMake: Fix SD paths CMake: Fix storage components paths Aug 25, 2020
@hugueskamba
Copy link
Collaborator

CI started

@0xc0170 0xc0170 mentioned this pull request Aug 25, 2020
Merged
6 tasks
@hugueskamba hugueskamba merged commit a3dc894 into ARMmbed:feature-cmake Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xc0170 @ciarmcom @hugueskamba