Skip to content

CMake Travis: add additional examples #13334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

CMake Travis: add additional examples #13334

merged 1 commit into from
Aug 28, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jul 22, 2020 •
edited by hugueskamba
Loading

Summary of changes

Add configuration that would allow us to build dozen of examples without too much duplications. As not all examples are yet updated, I'll clean it up and make it part of the CI check.

Impact of changes

Migration actions required

Documentation

Pull request type

  • Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
  • Feature update (New feature / Functionality change / New API)
  • Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

  • No Tests required for this change (E.g docs only update)
  • Covered by existing mbed-os tests (Greentea or Unittest)
  • Tests / results supplied as part of this PR

Reviewers

@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team July 22, 2020 13:00
@0xc0170 0xc0170 force-pushed the dev_cmake_add_travis_jobs branch 2 times, most recently from b2081b0 to d76c050 Compare July 22, 2020 14:07
hugueskamba
hugueskamba reviewed Jul 22, 2020
View reviewed changes
@mergify
Copy link

mergify bot commented Jul 22, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@hugueskamba
Copy link
Collaborator

You probably need to cherry-pick your commits to feature-cmake to resolve the conflicts.

@0xc0170 0xc0170 force-pushed the dev_cmake_add_travis_jobs branch from c98abd9 to 2d6ebed Compare July 23, 2020 08:11
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 23, 2020 •
edited
Loading

Rebased, also history fixed, so just one commit adding all examples we should support.

Ready for review, although blocked until we fix the examples.

@mergify
Copy link

mergify bot commented Jul 23, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 27, 2020

I'll rebase once I fix the rest of the examples otherwise it's rebase often with no benefits.

@hugueskamba hugueskamba force-pushed the feature-cmake branch 4 times, most recently from 8872419 to cb65e19 Compare August 3, 2020 15:16
@hugueskamba hugueskamba force-pushed the feature-cmake branch 3 times, most recently from 161a445 to 85477b1 Compare August 7, 2020 14:43
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 24, 2020

I've just rebased the branch to have the history clean and ready for review. Travis finally built all examples. There are errors we need to fix in the examples.

@hugueskamba
Copy link
Collaborator

I've just rebased the branch to have the history clean and ready for review. Travis finally built all examples. There are errors we need to fix in the examples.

Can you share the build output link? I cannot see it.

@mergify
Copy link

mergify bot commented Aug 24, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@hugueskamba
Copy link
Collaborator

Fix for NFC_EEPROM failure: ARMmbed/mbed-os-example-nfc#77

@0xc0170 0xc0170 force-pushed the dev_cmake_add_travis_jobs branch from b933cfc to 70f4ed1 Compare August 25, 2020 07:38
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 25, 2020

Fix for NFC_EEPROM failure: ARMmbed/mbed-os-example-nfc#77

merged. I rebased, lets see what is outstanding.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 25, 2020

Depends on #13488, I'll rebase once it is in.

@mergify
Copy link

mergify bot commented Aug 25, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170 0xc0170 force-pushed the dev_cmake_add_travis_jobs branch from 70f4ed1 to 9fe1b71 Compare August 26, 2020 09:58
hugueskamba
hugueskamba reviewed Aug 27, 2020
View reviewed changes
hugueskamba
hugueskamba reviewed Aug 27, 2020
View reviewed changes
@hugueskamba hugueskamba force-pushed the dev_cmake_add_travis_jobs branch 2 times, most recently from c961df3 to 76eea6d Compare August 27, 2020 16:09
@hugueskamba
Copy link
Collaborator

This force-push ensures that that the mbed-os repository stays on ${TRAVIS_PULL_REQUEST} before checking out every other lib dependencies.

@hugueskamba hugueskamba force-pushed the dev_cmake_add_travis_jobs branch 4 times, most recently from 8c2ef58 to 2a22a90 Compare August 27, 2020 16:51
@mergify
Copy link

mergify bot commented Aug 28, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@hugueskamba hugueskamba force-pushed the dev_cmake_add_travis_jobs branch from 2a22a90 to 8bfeec5 Compare August 28, 2020 13:04
@hugueskamba hugueskamba merged commit d91c3d7 into ARMmbed:feature-cmake Aug 28, 2020
@mergify mergify bot removed the ready for merge label Aug 28, 2020
@0xc0170 0xc0170 deleted the dev_cmake_add_travis_jobs branch August 31, 2020 09:43
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 31, 2020

Awesome to have this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba left review comments

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xc0170 @ciarmcom @hugueskamba