autocomplete [nfc]: Give subclasses control of computeResults #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither existing implementation of this method uses this parameter; it seems like the use of it should be the job of testItem anyway, not of getSortedItemsToTest.
This method, and its caller _startSearch, already assume that the query they're given is the current `_query`. Remove the parameter, to simplify away redundancy and avoid possible confusion on how the two query values relate.
I think I probably didn't know Dart had this feature when we originally wrote this loop.
These two methods were in between compareByRecency and compareByDms, which are closely-related siblings to each other. So move them outside that group.
This gives AutocompleteView subclasses the flexibility to have an implementation that's more than a single loop through candidates.
|
Thanks, LGTM! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives AutocompleteView subclasses the flexibility to have an implementation that's more than a single loop through candidates.
That will be useful for #234 / #889, /cc @sm-sayedi.
To keep the tricky aspects of the main search loop encapsulated, we move them into a helper function
filterCandidateswhich thosecomputeResultsimplementations can call.