Skip to content

Conversation

@gnprice
Copy link
Member

@gnprice gnprice commented Aug 8, 2024

Following up on #872 (comment) .

This fixes #825 because of the updates to file_picker 8.0.7 and
flutter_local_notifications_linux 4.0.1.

Holding back the Drift-related packages (drift, drift_dev, sqlparser)
just because there appear to be some changes there that require small
updates on our side, and today I'm catching up on things and so don't
have time to dig into those myself.

There are also some updates that tools/upgrade pub-major would
make beyond these, which I'm similarly leaving aside for the moment.

Fixes: #825

@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label Aug 8, 2024
@gnprice gnprice requested a review from chrisbobbe August 8, 2024 23:27
@gnprice
Copy link
Member Author

gnprice commented Aug 9, 2024

Updated to fix CI. The diff was just this:

-// Autogenerated from Pigeon (v20.0.1), do not edit directly.
+// Autogenerated from Pigeon (v20.0.2), do not edit directly.

at the top of the two Pigeon-generated files.

@chrisbobbe
Copy link
Collaborator

Thanks! LGTM. While testing this out, some .gitignore lines got added automatically:

diff --git .gitignore .gitignore
index 4fee86d2a..a6ec1f646 100644
--- .gitignore
+++ .gitignore
@@ -5,9 +5,11 @@
 *.swp
 .DS_Store
 .atom/
+.build/
 .buildlog/
 .history
 .svn/
+.swiftpm/
 migrate_working_dir/

Not sure why. There isn't a .build/ or a .swiftpm/ in the project directory.

@gnprice
Copy link
Member Author

gnprice commented Aug 13, 2024

Thanks! Merging.

While testing this out, some .gitignore lines got added automatically:

That sounds like something the flutter tool might do. It'd be concerning if a package dependency took it upon itself to edit the app's source tree like that.

… Yep, looks like this upstream commit:
flutter/flutter@29f332c

So a quick PR to apply that would be good.

This fixes zulip#825 because of the updates to file_picker 8.0.7 and
flutter_local_notifications_linux 4.0.1.

Holding back the Drift-related packages (drift, drift_dev, sqlparser)
just because there appear to be some changes there that require small
updates on our side, and today I'm catching up on things and so don't
have time to dig into those myself.

There are also some updates that `tools/upgrade pub-major` would
make beyond these, which I'm similarly leaving aside for the moment.

Fixes: zulip#825
@gnprice gnprice merged commit 8767297 into zulip:main Aug 13, 2024
@gnprice gnprice deleted the pr-deps branch August 13, 2024 02:43
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this pull request Aug 22, 2024
This change has been getting applied by `flutter run`, and Greg
identified this upstream commit as the cause:
  flutter/flutter@29f332c82

Discussion:
  zulip#873 (comment)
chrisbobbe added a commit that referenced this pull request Sep 3, 2024
This change has been getting applied by `flutter run`, and Greg
identified this upstream commit as the cause:
  flutter/flutter@29f332c82

Discussion:
  #873 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer review PR ready for review by Zulip maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin "default implementation" warnings on latest Flutter

2 participants