theme: Implement DesignVariables.dark #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
gnprice
reviewed
Jul 12, 2024
lib/widgets/theme.dart
Outdated
Comment on lines
78
to
79
| factory DesignVariables.light() { | ||
| return DesignVariables._( |
There was a problem hiding this comment.
nit: can simplify slightly:
Suggested change
| factory DesignVariables.light() { | |
| return DesignVariables._( | |
| DesignVariables.light() : | |
| this._( |
That's a Dart "redirecting constructor":
https://dart.dev/language/constructors#redirecting-constructors
chrisbobbe
force-pushed
the
pr-design-variables-dark
branch
from
660938a to
ab1c17c
Compare
|
Thanks for the review! Revision pushed. I've also added some stream-colors test coverage that's meant to be added here: |
gnprice
reviewed
Jul 12, 2024
| return const Placeholder(); | ||
| }))); | ||
| await tester.pumpAndSettle(); | ||
| debugFollowPlatformBrightness = true; |
There was a problem hiding this comment.
should also get an addTearDown call to reset
test/widgets/theme_test.dart
Outdated
| doTest('light', 0xff76ce90, StreamColorSwatch.light(0xff76ce90)); | ||
| // TODO(#95) test with Brightness.dark and lerping between light/dark | ||
| await tester.pump(kThemeAnimationDuration * 0.6); | ||
| check(colorSwatchFor(element, subscription)).equals(StreamColorSwatch.dark(baseColor)); |
There was a problem hiding this comment.
nit: wrap line, also making parallel to the light case above
Suggested change
| check(colorSwatchFor(element, subscription)).equals(StreamColorSwatch.dark(baseColor)); | |
| check(colorSwatchFor(element, subscription)) | |
| .equals(StreamColorSwatch.dark(baseColor)); |
Then might as well make the intermediate case parallel too: inline expectedLerped, and format the same way, like
check(colorSwatchFor(element, subscription))
.equals(StreamColorSwatch.lerp(
Comment on lines
+127
to
+131
| final element = tester.element(find.byType(Placeholder)); | ||
| // Compares all the swatch's members; see [ColorSwatch]'s `operator ==`. | ||
| check(colorSwatchFor(element, subscription)) |
For how I retrieved the current list of variables, see zulip#762 (comment) .
We can check the dark and lerped states conveniently without using this helper.
chrisbobbe
force-pushed
the
pr-design-variables-dark
branch
from
ab1c17c to
af2e178
Compare
|
Thanks! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.