Small NFC tweaks to message-move-related code #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets the Dart compiler see that these are definitely constant through the function (which it can't assume when they're getters on an object). That in turn lets it narrow the types based on our null checks, so that we can leave out `!` operators later. That's small now, but will be more useful as we add more logic to this function -- if we had to scatter `!` all around that logic, we'd have to wonder whether some of them were unjustified assumptions and might throw at runtime. Also rename one local to "newStreamId", matching the property it mirrors. We'll rename both the variable and the property together, as part of a sweep coming up soon (zulip#631).
This messageContentChanged method goes logically next to the various event-handling methods, rather than separated from them by notifyListeners and its siblings.
|
LGTM, thanks! Merged. |
|
Thanks for the swift review! For cross-reference, that subsequent draft PR with the main changes is #787. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to send all my draft changes toward #150 as a draft PR, so that @PIG208 can build on that without duplicating the work I did on that a couple of months ago.
This PR pulls out from that draft work a couple of small prep commits that are self-contained and ready to go, so that we can merge them (to reduce future merge conflicts) without blocking on the larger work.