Skip to content

msglist test: Backfill tests for rest of model; overhaul test setup #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 9, 2023
Merged

msglist test: Backfill tests for rest of model; overhaul test setup #260

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e7a227a
msglist test [nfc]: Stop using global store and binding in model test
gnprice Aug 9, 2023
1b6e598
msglist test [nfc]: Drop user and stream from store
gnprice Aug 9, 2023
f60d478
msglist test [nfc]: Cut file-wide userId constant
gnprice Aug 9, 2023
70be31f
msglist test [nfc]: Rename view-model locals as "model"
gnprice Aug 9, 2023
997e07a
msglist test: Simplify by using AllMessagesNarrow
gnprice Aug 9, 2023
4a4f8c4
msglist test [nfc]: Let eg.streamMessage pick the stream
gnprice Aug 9, 2023
2491cb7
msglist test [nfc]: Simplify findMessageWithId test slightly more
gnprice Aug 9, 2023
9a07d7d
msglist test [nfc]: Use package:checks idiom for properties of model
gnprice Aug 9, 2023
dbf86dd
msglist test: Use a realistic GetMessagesResult for fetch
gnprice Aug 9, 2023
fbbbbeb
msglist test: Overhaul setup of tests, with shared helpers
gnprice Aug 9, 2023
047c2ba
msglist test: Systematically check invariants of MessageListView
gnprice Aug 9, 2023
c5500b1
msglist test: Write tests for the rest of MessageListView
gnprice Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading