Use known, subscribed channels in more tests (prep for #1798) #1988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all of these tests, the message list's narrow is a ChannelNarrow, and all of the deleted messages are in that channel. The tests aren't about whether or not the deleted messages are in the message list's narrow; really they're about whether or not the deleted messages are present in the MessageListView model.
Before this, in all the tests touched here, we were exercising the message list with a channel that isn't actually in the PerAccountStore. When we don't pass `stream` to the `prepare` function, the function adds a *different* channel to the store, with a corresponding Subscription, having streamId eg.defaultStreamMessageStreamId. The normal, boring setup, which is suitable for all these tests, is to exercise the message list in a known, subscribed channel. Provide that setup by passing the same `stream` object to `prepare` that we use to create messages and narrows.
…boring The `prepare` helper, and now the prepare-outbox helpers, fall back to this channel ID when a different one isn't specified. That's sensible and lets these tests be a bit more compact. When tests use two different channels, with pairs of variables like `stream` and `otherStream`, or `stream1` and `stream2`, I let that be, even though it might be reasonable for some of them to use eg.defaultStreamMessageStreamId for one of the channels.
This is the boring, common case that makes sense to exercise here.
rajveermalviya
approved these changes
Nov 17, 2025
Member
rajveermalviya
left a comment
rajveermalviya
left a comment
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM, moving over to Greg's review.
rajveermalviya
added
integration review
rajveermalviya
requested review from
gnprice and
rajveermalviya
and removed request for
rajveermalviya
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main work here is to change several tests of
MessageListViewandMessageStoreso that the channels they exercise are actually known (i.e. present in the store) and subscribed, which we can consider the boring, common case. Without this change, some of these tests would fail when we change the behavior for unsubscribed channels, for #1798.Compare d6f2441 and f89ce2e, where we similarly changed the setup for various widget tests, also to prepare for #1798.
Related: #1798