Skip to content

Conversation

MritunjayTiwari14
Copy link

@MritunjayTiwari14 MritunjayTiwari14 commented Sep 28, 2025

This PR introduces several improvements to the HomePage bottom navigation bar, focusing on UI enhancements for clarity, new functionality, and accessibility.

Key Changes:

Dark Theme Light Theme
1000051472 1000051473

I have kept the height of the Navigation to be fixed because a fully dynamic navigation bar height that adjusts based on label content across languages is not feasibly after having done some feasibility study. The UI jitter when the bar changes its size suddenly when the user changes the app language is extremely unlikely to be solved and can negatively impact user experience hence even in day to day app these types of dynamic navigation bar are not used.

integration of the page bodies and semantics has been done

The font size for navigation bar is kept to 12px. This change addresses design feedback from Vlad and Alya, aiming for better readability..

Self Admitted Technical Dept:
* Language Consistency for all language for the added labels will be fixed after receiving feedback from the Moderators about the Implementation of the solution.

Thank you

Labeled the Navigation Bar for each Icon.
Height changes encorporated as discussed.

Fixes: zulip#1857
@MritunjayTiwari14
Copy link
Author

MritunjayTiwari14 commented Sep 28, 2025

@gnprice I would be extremely grateful if you could give a review to this PR for the Issue that you stated.

@gnprice
Copy link
Member

gnprice commented Sep 28, 2025

There is a lot of text to read in that PR description. Did you use ChatGPT or another LLM to write it? If so, we'd much rather see whatever prompt you used, instead of the LLM output — the LLM fundamentally doesn't add any information that wasn't there already, and the prompt should be a lot shorter and so less work to read.

There's also no need to repeat information that's there in the diffs, like the names of files you touched and identifiers you added there.

@gnprice
Copy link
Member

gnprice commented Sep 28, 2025

Please also add a test for this change, and organize into clear and coherent commits according to the Zulip style — those are our two general requirements for a PR. See the repo's README for details, and links to further details.

Once those are met, this will be ready for a review. After another maintainer has reviewed it and you've revised to address their comments, I'll review the PR.

@MritunjayTiwari14
Copy link
Author

MritunjayTiwari14 commented Sep 29, 2025

There is a lot of text to read in that PR description. Did you use ChatGPT or another LLM to write it? If so, we'd much rather see whatever prompt you used, instead of the LLM output — the LLM fundamentally doesn't add any information that wasn't there already, and the prompt should be a lot shorter and so less work to read.

There's also no need to repeat information that's there in the diffs, like the names of files you touched and identifiers you added there.

Although i did write the whole description in a paragraph, I use LLM to fine tune my description into a formatted output like a pointer and reformat it output again myself. I have changed the description to a brief one.

@MritunjayTiwari14
Copy link
Author

Please also add a test for this change, and organize into clear and coherent commits according to the Zulip style — those are our two general requirements for a PR. See the repo's README for details, and links to further details.

Once those are met, this will be ready for a review. After another maintainer has reviewed it and you've revised to address their comments, I'll review the PR.

Alright Greg

Added Gesture Detector over Column, Temporary
set the onPressed of the Icon Button to null.

Fixes: zulip#1808

home: Improve performace and fix bug.

Replaced IconButton widgets to Icon improve
significantly performace of switching screens
and wrote test for the semantic labels for App Bar.

Fixes: zulip#1879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants