Rely on Zulip Server 6 APIs #1869
Conversation
Issue zulip#992 was closed as a duplicate of zulip#1837, and zulip#1838 exists as the issue for TODO(server-7) comments.
The doc for this says > This field is only included when its value is `true`. so the TODO(server-6) isn't reason enough to make it a required field. Fixes-partly: zulip#1837
This isn't a case of special backward-compat code to be trimmed out; the backwards compatibility was simply that older servers wouldn't exercise this code. Fixes-partly: zulip#1837
Fixes-partly: zulip#1837
…read" Fixes-partly: zulip#1837
…value Fixes-partly: zulip#1837
… bugs Fixes-partly: zulip#1837
chrisbobbe
force-pushed
the
pr-clear-todo-server-6
branch
from
f29237b to
4a8cebc
Compare
rajveermalviya
added
integration review
There was a problem hiding this comment.
Thanks for cleaning these up! Generally all looks good. A few comments below.
In addition to the TODO-server comments in our code, I also took this as a prompt to read through the API changelog https://zulip.com/api/changelog for Server 6. Items I found there which should also be part of relying on Server 6:
- FL-139: no more
in_home_viewinsubscription/updateevents - FL-148: no more
awayin user status, which we had commented out
Also grepped -i for server.?6 at the tip of the branch; the only match was that FL-148 removal of away.
| final UserSettings userSettings; | ||
|
|
||
| final List<UserTopicItem>? userTopics; // TODO(server-6) | ||
| final List<UserTopicItem> userTopics; |
There was a problem hiding this comment.
This replaced muted_topics. Grepping (with git grep -i muted.?topic`), we have a commented-out reference to that, above, which we can delete.
Also a comment in the list of event types.
| GetMessagesResult olderGetMessagesResult({ | ||
| required int anchor, | ||
| bool foundAnchor = false, // the value if the server understood includeAnchor false | ||
| bool foundAnchor = false, |
There was a problem hiding this comment.
This should mean we can drop this parameter, right? And just hard-code the value in this test helper's body. (Because we no longer need to exercise scenarios where it has any other value.)
| topics.update(topic, | ||
| ifAbsent: () => messageIds, | ||
| // setUnion dedupes existing and incoming unread IDs, | ||
| // so we tolerate zulip/zulip#22164, fixed in 6.0 | ||
| // TODO(server-6) remove 6.0 comment | ||
| (existing) => setUnion(existing, messageIds), | ||
| ); | ||
| (existing) => setUnion(existing, messageIds)); | ||
| } | ||
|
|
There was a problem hiding this comment.
This comment appears to have been explaining why we had this setUnion. Do we no longer need it?
Fixes #1837.
This isn't our most urgent issue, but I was looking for some low-hanging fruit I could clear during yesterday's heat wave when it was really hot and uncomfortable at home. :)