compose [nfc]: Use ComposeBoxController.uploadFiles in _AttachUploadsButton #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
added
the
integration review
…Button In e4deccb (zulip#1774) ComposeBoxController started exposing an uploadFiles method, which is now used by the Share-to-Zulip implementation. So use that for _AttachUploadsButton too, so as to use the same implementation between Share-to-Zulip and compose box upload buttons.
|
Thanks for the follow-up! Looks good; merging. Fixed one nit in the commit message: It's helpful to add the PR number for context next to the commit ID: |
gnprice
force-pushed
the
pr-update-upload-button
branch
from
16a5e94 to
7249b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e4deccb ComposeBoxController started exposing uploadFiles method, which is now used by Share-to-Zulip implementation. So use that for _AttachUploadsButton too, using the same implementation between Share-to-Zulip and compose box upload buttons.