scrolling test: Skip tests against old default z-order of slivers #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tests on CustomPaintOrderScrollView compare its behavior to the default z-order / paint order behavior of CustomScrollView. They'd therefore be broken by my upstream PR that gives CustomScrollView the functionality of CustomPaintOrderScrollView and simplifies its default behavior: flutter/flutter#164818 So skip the tests. Once that PR lands, we can update past it and then remove CustomPaintOrderScrollView and its tests entirely. (The customer_tests failures currently seen on the upstream PR are different, because the Zulip pin in flutter/tests is currently at d302584. The failures there are in the sticky_header tests, which want to exercise a variety of sliver configurations and need to control the z-order when they do so. As of d302584, they did so by relying on the specifics of the existing CustomScrollView behavior. Since then we merged CustomPaintOrderScrollView, and in 49eff8b adapted those tests to use it, making them immune to changes in the default z-order; but that also meant adding CustomPaintOrderScrollView's own tests, including these two.)
Collaborator
|
Thanks, LGTM! Merged. |
gnprice
added a commit
to gnprice/flutter_customer_testing
that referenced
this pull request
Apr 23, 2025
This updates to the following change in Zulip: zulip/zulip-flutter#1480 zulip/zulip-flutter@88e7bcc in order to unblock this PR: flutter/flutter#164818
8 tasks
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Apr 24, 2025
This updates to the following change in Zulip: zulip/zulip-flutter#1480 zulip/zulip-flutter@88e7bcc in order to unblock this PR: flutter/flutter#164818 > [!IMPORTANT] > This repository is a testing suite that contains references to tests (in the `registry` directory) that are run with every commit to Flutter > to verify that no breaking changes have been introduced (in the "customer_testing" shards). Your merged PR is _not_ automatically run in the > Flutter CI tree. > > After merging this PR, you must send another PR to flutter/flutter updating `dev/customer_testing/tests.version` in that repo with the latest git commit SHA of the flutter/test repo. > > See <flutter/flutter#162048> for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests on CustomPaintOrderScrollView compare its behavior to the default z-order / paint order behavior of CustomScrollView. They'd therefore be broken by my upstream PR that gives CustomScrollView the functionality of CustomPaintOrderScrollView and simplifies its default behavior:
flutter/flutter#164818
So skip the tests. Once that PR lands, we can update past it and then remove CustomPaintOrderScrollView and its tests entirely.
(The customer_tests failures currently seen on the upstream PR are different, because the Zulip pin in flutter/tests is currently at d302584. The failures there are in the sticky_header tests, which want to exercise a variety of sliver configurations and need to control the z-order when they do so. As of d302584, they did so by relying on the specifics of the existing CustomScrollView behavior. Since then we merged CustomPaintOrderScrollView, and in 49eff8b adapted those tests to use it, making them immune to changes in the default z-order; but that also meant adding CustomPaintOrderScrollView's own tests, including these two.)