ci: Update workaround for broken ref for Flutter upstream main #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
referenced
this pull request
Dec 19, 2024
Fixes #1177. Workaround for: flutter/flutter#160558
Fixes zulip#1177, take 2. The original hacky workaround subsequently broke after the upstream change that fixed the "upstream" vs. "origin" part of the issue. We still need a version of this workaround, though, because we clone the repo with the branch `main`, which in the Flutter repo always points to the same commit as `master`.
gnprice
force-pushed
the
pr-ci-flutter-ref
branch
from
e37f033 to
f2458b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177, take 2.
The original hacky workaround subsequently broke after the upstream change that fixed the "upstream" vs. "origin" part of the issue. We still need a version of this workaround, though, because we clone the repo with the branch
main, which in the Flutter repo always points to the same commit asmaster.