Series of prep commits for topic action sheet related changes #1125
Conversation
There was a problem hiding this comment.
Thanks!
I'll go ahead and merge this. @chrisbobbe I believe you were done with reviews on this part of #1041, based on your last couple of reviews there.
The tiny last commit at the end, I'm not sure I like the API change it makes. (Comment below.) So I'll leave that one out.
lib/widgets/message_list.dart
Outdated
| return GestureDetector( | ||
| behavior: HitTestBehavior.translucent, | ||
| onLongPress: () => showMessageActionSheet(context: context, message: message), | ||
| onLongPress: () => showMessageActionSheet(context, message: message), |
There was a problem hiding this comment.
I guess this one last commit doesn't convince me:
53a24b0 action_sheet [nfc]: Make showMessageActionSheet's context an unnamed param
The existing API there matches that of upstream's showModalBottomSheet. I think in turn the idea there is that it's similar in flavor to a widget constructor; and those always take all named arguments.
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
gnprice
force-pushed
the
pr-muting-prep
branch
from
53a24b0 to
cf19d68
Compare
|
Merged. @rajveermalviya FYI — this version has fixed that issue you discovered when combining #1103 with the corresponding commits in a previous revision of #1041, so I expect a merge conflict but it should be easy to fix by just dropping the commits that came from #1041 when you rebase #1103 atop the new main. |
2 participants
Taken from #1041.
Other PRs that rely on this:
Requested by @gnprice here.