Skip to content

Conversation

StefanosChaliasos
Copy link
Collaborator

@StefanosChaliasos StefanosChaliasos commented Mar 4, 2025

In this PR we try to implement #13. This is still wip:

  • DFA checker: will check if a regex has multiple accepted states
  • DFA converter: will try to fix non-accepted regexes
  • DFA generator
  • DFA input generator
  • Merge with the rest of the code (generator and input gen)

Non-DFA related features:

  • Split the regex based on the first part (which should be only the beginning anchor ^ and the rest which could be public so we can check the reveal bits)
  • Check Reveal bits and handle groups
  • Use transform_dfa_to_single_accepting_state, we need to wrap it
  • Update and use check_zkregex_rules_basic

@StefanosChaliasos
Copy link
Collaborator Author

One issue we had was that the automata library did not handle character classes. This PR should fix it.

@StefanosChaliasos
Copy link
Collaborator Author

@Merricx, let's implement the rest TODOs in a different PR

Copy link
Collaborator

@Merricx Merricx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@StefanosChaliasos StefanosChaliasos merged commit d1c7070 into main Mar 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants