add vim popup support #19
Conversation
|
@pale3 I think we can add a switch to open the panel. Because some people want to show blame-info weakly, others strongly with panel. |
|
By switch, you mean to allow user to choose wether popup should be used or echomsg? |
| endfunction | ||
|
|
||
| function! gitblame#echo() | ||
| let l:blank = ' ' | ||
| let l:file = expand('%') | ||
| let l:line = line('.') | ||
| let l:gb = gitblame#commit_summary(l:file, l:line) | ||
|
|
||
| " if vim has support for popup we will use it, unless stated otherwise | ||
| if (g:GBlameUsePopup) |
There was a problem hiding this comment.
Undefined variable: g:GBlameUsePopup.
Please check the case that not "patch-8.1.1522"
There was a problem hiding this comment.
I understand issue here. Will be fixed when i get free time..
| @@ -10,6 +10,10 @@ if has('nvim-0.3.2') | |||
| let g:GBlameVirtualTextEnable = 0 | |||
| endif | |||
|
|
|||
| if has("patch-8.1.1522") | |||
There was a problem hiding this comment.
Somewhere around this, popup has been implemented
|
This PR seems to just... work? Anyway |
I dont use this anymore, feel free to modify this if needed |
|
Sorry, I meant this for @zivyangll ; I was wondering why this is not merged (i.e. are there any remaining problems?) |
@zivyangll
This patch add vim popup support with syntax hi. Also there was some other minor changes, take a look