Skip to content

Update Zig master @branchHint and builtin type fields #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 31, 2024
Merged

Update Zig master @branchHint and builtin type fields #2011

merged 6 commits into from
Aug 31, 2024

Conversation

@mochalins
Copy link
Contributor

@mochalins mochalins commented Aug 27, 2024

No description provided.

@mochalins
Copy link
Contributor Author

mochalins commented Aug 27, 2024

Minimum Zig version not available to CI yet, must re-run once available. Tests pass locally on Linux x86_64. Tests fail for x86_64 Windows through Wine, for what appear to be Wine-specific reasons (hundreds of fixme and XXX not implemented yet errors logged during test).

@llogick llogick mentioned this pull request Aug 28, 2024
Closed
@xdBronch
Copy link
Contributor

xdBronch commented Aug 29, 2024 •
edited
Loading

there are some more breaking changes on master, ziglang/zig#21225 and possibly ziglang/zig#21231 eventually (havent checked if this one affects zls)(it doesnt). could maybe do them all here so there arent multiple prs trying to update?

@mlugg
Copy link
Contributor

mlugg commented Aug 29, 2024

breaking changes are my passion

@mochalins
Copy link
Contributor Author

mochalins commented Aug 29, 2024

there are some more breaking changes on master, ziglang/zig#21225 and possibly ziglang/zig#21231 eventually (havent checked if this one affects zls). could maybe do them all here so there arent multiple prs trying to update?

Sure, will do!

@devraymondsh
Copy link

devraymondsh commented Aug 31, 2024

Still waiting for this fix to be merged.

@mochalins
Copy link
Contributor Author

mochalins commented Aug 31, 2024 •
edited
Loading

Updated with all tests passing on latest master (0.14.0-dev.1392+37df6ba86) on x86_64 Linux. Depends on zigtools/lsp-kit#18, build.zig.zon must be updated after it is merged.

@mochalins mochalins changed the title Update Zig master @branchHint Update Zig master @branchHint and builtin type fields Aug 31, 2024
mochalins and others added 3 commits September 1, 2024 01:44
@mochalins
scm: zig-lsp-codegen update for builtin fields
83434d0
@Techatrix
update deps.nix for zig-lsp-codegen
99a297e
@Techatrix
flake.lock: Update
de85676 
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/224042e9a3039291f22f4f2ded12af95a616cca0' (2024-08-21)
  → 'github:NixOS/nixpkgs/6e99f2a27d600612004fbd2c3282d614bfee6421' (2024-08-30)
• Updated input 'zig-overlay':
    'github:mitchellh/zig-overlay/1f0785c9b064455d5ba78002470f6dfad65de2a8' (2024-08-22)
  → 'github:mitchellh/zig-overlay/695df248dde30f61298951a8d96faa984ac84581' (2024-08-31)
Techatrix
Techatrix approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@Techatrix Techatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Techatrix Techatrix merged commit af8ed6a into zigtools:master Aug 31, 2024
@mochalins mochalins deleted the branch_hint branch August 31, 2024 16:57
@Techatrix Techatrix mentioned this pull request Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techatrix Techatrix Techatrix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mochalins @xdBronch @mlugg @devraymondsh @Techatrix