stage2 ARM: more instructions, return values, parameters #6255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachimschmidt557
force-pushed
the
stage2-arm
branch
3 times, most recently
from
0b8b044 to
ce94667
Compare
Merged
joachimschmidt557
force-pushed
the
stage2-arm
branch
2 times, most recently
from
cf18456 to
4a29789
Compare
joachimschmidt557
force-pushed
the
stage2-arm
branch
from
4a29789 to
927a763
Compare
Contributor
Author
|
I'll add some testcases for basic parameters, return types and non-leaf functions. After that, I'll mark this ready for review. |
Vexu
reviewed
Sep 26, 2020
joachimschmidt557
force-pushed
the
stage2-arm
branch
from
82c45ce to
221d267
Compare
Contributor
Author
|
Seems like some conflicts appeared. I'll rebase and resolve those. |
Non-leaf functions now work. Combined with simple parameters and return types, this allows more complicated programs than Hello World to be correctly compiled.
joachimschmidt557
force-pushed
the
stage2-arm
branch
from
221d267 to
6d0ac9f
Compare
joachimschmidt557
force-pushed
the
stage2-arm
branch
from
6d0ac9f to
fb58fb2
Compare
andrewrk
approved these changes
Oct 4, 2020
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Really nice work @joachimschmidt557. Thanks for being patient with my big breaking changes.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some more stuff to stage2 ARM backend