zig fmt: Fix relative paths with . and .. on Windows as well as forward slashes #5187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a band-aid fix due to NtCreateFile failing on paths with . or .. in them.
The previous commit made zig fmt print absolute paths; this commit keeps the absolute path resolution but still prints the relative paths to stdout.
andrewrk
changed the title
Member
|
Looks good to me. 👍 |
|
|
||
| const max = std.math.maxInt(usize); | ||
| const source_code = fs.cwd().readFileAlloc(fmt.allocator, file_path, max) catch |err| switch (err) { | ||
| const source_code = fs.cwd().readFileAlloc(fmt.allocator, real_path, self_hosted_main.max_src_size) catch |err| switch (err) { |
Contributor
There was a problem hiding this comment.
Isn't real_path an absolute path? Why call fs.cwd()?
squeek502
added a commit
to squeek502/zig
that referenced
this pull request
May 23, 2021
Added in ziglang#4655/ziglang#5187, obsoleted by ziglang#7664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @squeek502's pull request #4655 with a couple of additional modifications.
@squeek502 does this look OK to you?
I also plan on looking into making "." and ".." work in the code that calls
NtCreateFilebut I agree with you that can be a separate issue.