target: Implement OS version detection for OSX #4589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
reviewed
Feb 29, 2020
lib/std/zig/system.zig
Outdated
| .macosx => { | ||
| // TODO Detect native operating system version. | ||
| var product_version: [32]u8 = undefined; | ||
| var size: usize = @sizeOf(@TypeOf(product_version)); |
Member
There was a problem hiding this comment.
Better to use product_version.len here. If the type was changed to e.g. a slice then it would still be correct instead of a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If needed we can implement a fallback for some older versions using
kern.osreleaseand a table mapping the kernel version to the osx one (see here for more info).Closes #4583