std.zig.system: Move CPU feature hacks after ABI detection.
#22526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
reviewed
Jan 18, 2025
Contributor
Rexicon226
left a comment
Rexicon226
left a comment
There was a problem hiding this comment.
Whoops, my bad! I should have noticed that those hacks are modifying cpu and not the query.
This was accidentally broken in ziglang#22434.
alexrp
force-pushed
the
cpu-feature-hacks
branch
from
62b79a9 to
515c970
Compare
Member
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally broken in #22434. See #22513 (comment) for an explanation.
cc @andrewrk @Rexicon226