AstGen: do not allow unlabeled break to exit a labeled switch
#21385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlugg
force-pushed
the
switch-break-unlabeled
branch
from
2c1c21b to
9ce93da
Compare
`break`ing from something which isn't a loop should always be opt-in. This was a bug in ziglang#21257.
mlugg
added a commit
to mlugg/zig
that referenced
this pull request
Sep 15, 2024
Also, start using labeled switch statements when dispatching maybe-runtime instructions like condbr to comptime-only variants like condbr_inline. This can't be merged until we get a zig1.wasm update due to ziglang#21385. Resolves: ziglang#21405
mlugg
added a commit
to mlugg/zig
that referenced
this pull request
Oct 27, 2024
Also, start using labeled switch statements when dispatching maybe-runtime instructions like condbr to comptime-only variants like condbr_inline. This can't be merged until we get a zig1.wasm update due to ziglang#21385. Resolves: ziglang#21405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking from something which isn't a loop should always be opt-in. This was a bug in #21257.