glibc: Pass -Qunused-arguments when building libc_nonshared.a.
#21119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some platforms, the math-related flags are ignored and produce warnings. There's nothing we can do about that, so just silence them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some platforms, the math-related flags are ignored and produce warnings. There's nothing we can do about that, so just silence them.
This started showing up after #20909. For example, for
mips64-linux-gnuabi64.2.32:The warning is confusingly worded; it's just informing us that it's disabling rounding math despite us passing
-frounding-math. So it's the same as if we hadn't passed-frounding-mathin the first place.