Allow setting PGID in std.process.Child.spawn #20556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
reviewed
Jul 17, 2024
andrewrk
approved these changes
Jul 21, 2024
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Ready to merge. Would you mind rebasing to solve the conflicts?
Member
|
Thanks! |
Contributor
Author
|
Awesome, thanks! |
auto-merge was automatically disabled
July 21, 2024 10:31
Head branch was pushed to by a user without write access
Member
|
Please rebase one more time; we had failures on master branch. I would do it for you but you have unchecked "allow edits from maintainers". |
Contributor
Author
|
Thanks, although the std-docs build for macOS on amd64 is failing mysteriously (some cache file not found), despite the same job runs fine on the base commit 179a6e6 on master. I will enable the allow edits thingie and defer it to you maintainers who know better of what's going (wr)on(g). |
Member
|
Sorry for the trouble, I will take it from here. |
Contributor
Author
|
Thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.process.Child is a nice abstraction, and it could be nicer if it can set the process group ID, which is useful if we want to kill that process and all its descendants.
Please let me know if backward compatibility in Child.kill's signature should be broken, or a
killpgfunction should be added instead.Slightly relevant: should Child.kill let caller choose the signal?