Follow-up: zig fetch: resolve branch/tag names to commit SHA
#19941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commit"" This reverts commit 6ca4ed5.
rohlem
reviewed
May 11, 2024
| /// Indicates whether the task aborted due to an out-of-memory condition. | ||
| oom_flag: bool, | ||
| /// If `use_latest_commit` was true, this will be the commit that was used. | ||
| latest_commit: ?git.Oid, |
Contributor
There was a problem hiding this comment.
This has an optional type, but is it ever null?
From a quick glance at the diff it seems to only be initialized to undefined, and only at one point assigned want_oid, which afaict is non-optional. (It's possible I missed something though.)
If there's no logical state using the null value we could make the field non-optional.
Contributor
Author
There was a problem hiding this comment.
Nice catch!
This was a few months ago, so my memory is a bit hazy, but I think it was made optional because not everything you can fetch is a git-repository, so the field would not necessary get initialized. But you are right, it should not be set to undefined everywhere, but null!
Member
|
Nice, thanks for the follow-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issues raised by @andrewrk in the original PR #19349 (reverted):
--save-exact=[name]std.Uri.Component.format