Tweak windows.UNWIND_HISTORY_TABLE for mem.zeroes compatibility
#17340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayschwa
force-pushed
the
windows-undwind-history-table
branch
from
7d14eca to
edb7e48
Compare
jayschwa
changed the title
windows.UNWIND_HISTORY_TABLE as undefinedwindows.UNWIND_HISTORY_TABLE for mem.zeroes compatibility
`mem.zeroes` was not compatible with the structure because it contained non-nullable pointers. Those pointers have been made nullable.
jayschwa
force-pushed
the
windows-undwind-history-table
branch
from
edb7e48 to
048c6a6
Compare
Contributor
Author
|
I found something that works and moved the changes back into #17286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mem.zeroeswas not compatible with the structure because it contained non-nullable pointers. Those pointers have been made nullable.This PR is spun off from #17286 in an attempt to isolate Windows CI failures.