std.Build.ConfigHeader: Override include guard for blank style #17310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds an optional field in the blank Style to allow for overriding the default header guard that is generated from the output file path.
i.e. now you can do
to get
The motivation for this is the case when multiple dependencies generate the same
config.hwith the same include guard, which ends up causing problems when both headers are included in the same translation unit. With this option, there is an escape hatch to define an include guard with a name that is less likely to conflict.A minor source incompatibility of this MR is that you can't specify the blank Style only with the enum literal, but must now coerce from the empty tuple (i.e.
.{}, I'm not 100% familiar with the terminology yet 😅).i.e. if you don't want the override, you now have to do
instead of
Not sure how to avoid this though. The alternative is putting this field in the main Options struct but that doesn't seem appropriate because the override only matters for the blank Style.