Skip to content

Conversation

@squeek502
Copy link
Member

@squeek502 squeek502 commented Sep 27, 2023

From, #17221 (comment), the current strategy with resinator is option 1:

Put Aro in src/, don't mark it as vendored, allow tight coupling with other compiler code, and periodically port code back and forth between the Zig source tree and the Aro source tree.

so it would be good if I were notified of any PRs that modify the files in src/resinator

EDIT: Nevermind, looks like CODEOWNERS only works for people with write access to the repo.

The people you choose as code owners must have write permissions for the repository.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@squeek502 squeek502 closed this Sep 27, 2023
@andrewrk
Copy link
Member

Invited you to have write access :-)

@andrewrk andrewrk reopened this Sep 27, 2023
@squeek502
Copy link
Member Author

Nice, thanks!

@andrewrk andrewrk merged commit de4d1ea into ziglang:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants