Windows: Fix TooManyParentDirs handling for paths that shouldn't be cwd-relative
#16783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a relative path like
..would:TooManyParentDirsRtlGetFullPathName_Uto do the necessary path resolution, butRtlGetFullPathName_Ualways resolves relative paths relative to the CWDInstead, when
error.TooManyParentDirsoccurs, we now look up the path of the passed indir(if it's non-null) and append the relative path to it before giving it toRtlGetFullPathName_U. Ifdiris null, then we just give itRtlGetFullPathName_Udirectly and let it resolve it relative to the CWD.Closes #16779
Before this PR, the added test would have failed with something like: