std: Move TTY from std.debug to std.io and add missing colors #15806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusg
force-pushed
the
std-io-tty
branch
2 times, most recently
from
4f8d700 to
1d614f9
Compare
Collaborator
Author
|
I've pushed an update to make colors not bold by default (the
|
Vexu
reviewed
May 22, 2023
Member
Vexu
left a comment
Vexu
left a comment
There was a problem hiding this comment.
Could std.io.detectTTYConfig be std.io.TTY.detectConfig instead?
ghost
reviewed
May 22, 2023
linusg
force-pushed
the
std-io-tty
branch
3 times, most recently
from
7aa64c8 to
5c2a45f
Compare
Also get rid of the TTY wrapper struct, which was exlusively used as a namespace - this is done by the tty.zig root struct now. detectTTYConfig has been renamed to just detectConfig, which is enough given the new namespace. Additionally, a doc comment had been added.
Also make colors not bold by default, that's what .bold is for.
daurnimator
reviewed
May 26, 2023
| // Per https://github.com/WebAssembly/WASI/issues/162 ANSI codes | ||
| // aren't currently supported. | ||
| return .no_color; | ||
| } else if (process.hasEnvVarConstant("ZIG_DEBUG_COLOR")) { |
Contributor
There was a problem hiding this comment.
This doesn't feel right to introduce
Collaborator
Author
There was a problem hiding this comment.
Purely moved, I didn't make any additions not mentioned in the proposal.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15804.