-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
build: rename std.Build.*Step to std.Build.Step.* #15020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,11 @@ | |
| //! TODO: make this more flexible, supporting more kinds of checks. | ||
| //! TODO: generalize the code in std.testing.expectEqualStrings and make this | ||
| //! CheckFileStep produce those helpful diagnostics when there is not a match. | ||
| const CheckFileStep = @This(); | ||
| const std = @import("std"); | ||
| const Step = std.Build.Step; | ||
| const fs = std.fs; | ||
| const mem = std.mem; | ||
|
Comment on lines
+5
to
+9
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Saw |
||
|
|
||
| step: Step, | ||
| expected_matches: []const []const u8, | ||
|
|
@@ -80,9 +85,3 @@ fn make(step: *Step, prog_node: *std.Progress.Node) !void { | |
| } | ||
| } | ||
| } | ||
|
|
||
| const CheckFileStep = @This(); | ||
| const std = @import("../std.zig"); | ||
| const Step = std.Build.Step; | ||
| const fs = std.fs; | ||
| const mem = std.mem; | ||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||
| const std = @import("../std.zig"); | ||||
| const std = @import("std"); | ||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting. Should files in the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to note in order to do this type of thing in non-std modules you have to add the module to its own dependencies: #14708 (comment)
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was wondering if we could avoid relative path on std import. It seems yes, we are already doing this in Line 76 in 5df31f3
|
||||
| const assert = std.debug.assert; | ||||
| const fs = std.fs; | ||||
| const macho = std.macho; | ||||
|
|
||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these decls are in the right file location but not the right namespace and does not implement the title as stated