std.http.Client.Response: Support any header #14856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Preferably we would wait for #14762 to be merged so I can update this PR. |
gaetschwartz
force-pushed
the
http-client-custom-headers
branch
from
816aceb to
b445bbf
Compare
Contributor
|
#14762 is merged |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom headers in the http Client.
Tangential
Additionnally, according to RFC 2822, Section 2.2 (and common conception) the first line of an HTTP request is not a header. It is called a "status line" by RFC 2616 Section 6.1.
It thus feels somewhat weird to me that we consider the status and the http version as headers, accessing them as if the http response somewhat looked like that.
Let me know if it's something we want to address in which case I can edit my PR to make that change as well. To me both status and version should be fields of the response rather than response's header field.