Update fmt to handle non-pointer struct/union/enum #1380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #1109 was merged we cannot be sure that a struct/union will be passed as a pointer. It might be better to implement this fix in the opposite direction: if it is a pointer, pass `value.*` back into `formatType`.
|
I did have to do it the other way because the address of a by-value parameter is not meaningful. I also added basic support for printing structs via reflection. The case when structs have pointers to themselves is not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1109 was merged we cannot be sure that a struct/union will be passed as a pointer. It might be better to implement this fix in the opposite direction: if it is a pointer, pass
value.*back intoformatType.