autodoc: various improvements #12347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 6, 2022 15:01
"Dialog" is the incorrect term here because a dialog is a separate window that still lets you use the app but a modal is a window where you can't continue using the app until you close it.
This new search placeholder looks much nicer because it allows HTML inside it which the `placeholder` attribute on `<input>`s doesn't allow. I tested it for all kinds of cases and it seems to work pretty well.
This fixes the new search placeholder not disappearing if you type before it finished loading, and maybe some other things.
This is mostly manually formatted. I couldn't find a good HTML formatter for this file. It also converts a bunch of tabs to spaces.
These should never be reassigned.
You can see this issue in the video.
Member
|
The video is super nice to see the changes made in the PR 👍 |
Member
|
Thank you very much, both the code and the UI improvements are appreciated, if you have other minor improvements please feel free to PR them and if you want to discuss bigger changes feel free to open an Issue or come chat in #autodoc in the big Zig discord server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accumulated a bunch of improvements for autodoc's frontend here. See the commits for more info.
Here you can see the new
<kbd>, the new search placeholder, the way the help modal closes when you click outside of it, and the light mode issue that I fixed in the last commit:2022-08-06.16-02-56.mp4
Now the help modal looks like this in light mode:
