Skip to content

Conversation

@Vexu
Copy link
Member

@Vexu Vexu commented Jun 5, 2022

This gets us to three unique errors:

std/io/reader.zig:206:26: error: unreachable else prong; all cases already handled           (#11798)
std/net.zig:1340:12: error: unable to resolve inferred error set
std/crypto/aes/aesni.zig:182:20: error: TODO implement Sema for asm with more than 1 output

Closes #11788
Closes #11162

@andrewrk
Copy link
Member

andrewrk commented Jun 5, 2022

stage2: use correct type (u29) for alignment

Ah, on this one I wanted to change the spec to make alignment u16. I can make a corresponding (and breaking) stage1 change along with this.

That said, since you did it in a separate commit that is easily revertable we could also move forward with this and make the change later.

@Vexu
Copy link
Member Author

Vexu commented Jun 5, 2022

That said, since you did it in a separate commit that is easily revertable we could also move forward with this and make the change later.

Either way works for me, std.heap.testAllocatorAlignedShrink currently depends on the u29 alignment.

@andrewrk
Copy link
Member

andrewrk commented Jun 5, 2022

Your call. If you have the PR green I certainly would not want to block the merge on the alignment type issue which we can do later.

@andrewrk andrewrk merged commit 367e2b2 into ziglang:master Jun 6, 2022
@andrewrk
Copy link
Member

andrewrk commented Jun 6, 2022

Made 2 tiny fixups upon merging:

  • added an extra assertion to one of new behavior tests
  • fixed typo in commit message

Great work!

TUSF pushed a commit to TUSF/zig that referenced this pull request May 9, 2024
`zig2 build test-std` progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AstGen doesn't pass type to switch prong Aggregate initializers should allow initializing comptime fields, verifying equality

2 participants