-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed as not planned
Labels
bugObserved behavior contradicts documented or intended behaviorObserved behavior contradicts documented or intended behaviorcontributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.This issue is limited in scope and/or knowledge of Zig internals.os-windows
Milestone
Description
Zig Version
0.13.0-dev.75+5c9eb4081
Mismatched signatures
GetCurrentDirectoryW
zig/lib/std/os/windows/kernel32.zig
Line 178 in 084c2cd
pub extern "kernel32" fn GetCurrentDirectoryW(nBufferLength: DWORD, lpBuffer: ?[*]WCHAR) callconv(WINAPI) DWORD;
lpBuffershould be null-terminated according to https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getcurrentdirectoryFormatMessageW
zig/lib/std/os/windows/kernel32.zig
Line 160 in 084c2cd
pub extern "kernel32" fn FormatMessageW(dwFlags: DWORD, lpSource: ?LPVOID, dwMessageId: Win32Error, dwLanguageId: DWORD, lpBuffer: [*]u16, nSize: DWORD, Arguments: ?*va_list) callconv(WINAPI) DWORD;
lpBuffershould be null-terminated according to https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-formatmessagewGetEnvironmentVariableW
zig/lib/std/os/windows/kernel32.zig
Line 189 in 084c2cd
pub extern "kernel32" fn GetEnvironmentVariableW(lpName: LPWSTR, lpBuffer: [*]u16, nSize: DWORD) callconv(WINAPI) DWORD;
lpBuffershould be null-terminated according to https://learn.microsoft.com/en-us/windows/win32/api/processenv/nf-processenv-getenvironmentvariablewGetModuleFileNameW
zig/lib/std/os/windows/kernel32.zig
Line 199 in 084c2cd
pub extern "kernel32" fn GetModuleFileNameW(hModule: ?HMODULE, lpFilename: [*]u16, nSize: DWORD) callconv(WINAPI) DWORD;
lpFilenameshould be null-terminated according to https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-getmodulefilenamewGetFullPathNameW
zig/lib/std/os/windows/kernel32.zig
Lines 220 to 225 in 084c2cd
pub extern "kernel32" fn GetFullPathNameW( lpFileName: [*:0]const u16, nBufferLength: u32, lpBuffer: [*]u16, lpFilePart: ?*?[*:0]u16, ) callconv(@import("std").os.windows.WINAPI) u32;
lpBuffershould be null-terminated according to https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfullpathnamew
Fixing these would be a breaking change.
Expected Behavior
extern signatures should be correct
rohlem
Metadata
Metadata
Assignees
Labels
bugObserved behavior contradicts documented or intended behaviorObserved behavior contradicts documented or intended behaviorcontributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.This issue is limited in scope and/or knowledge of Zig internals.os-windows