Skip to content

fix zig.buildOnSaveArgs config option not being sent over to ZLS #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+8 −1
Merged

fix zig.buildOnSaveArgs config option not being sent over to ZLS #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/zls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,12 @@ function configurationMiddleware(params: ConfigurationParams): LSPAny[] | Respon
if (typeof value === "string") {
// Make sure that `""` gets converted to `undefined` and resolve predefined values
value = value ? zigUtil.handleConfigOption(value, workspaceFolder ?? "guess") : undefined;
} else if (typeof value === "object" && value !== null && !Array.isArray(value)) {
} else if (Array.isArray(value)) {
value = value.map((elem: unknown) => {
if (typeof elem !== "string") return elem;
return zigUtil.handleConfigOption(elem, workspaceFolder ?? "guess");
});
} else if (typeof value === "object" && value !== null) {
// Recursively update the config options
const newValue: Record<string, unknown> = {};
for (const [fieldName, fieldValue] of Object.entries(value)) {
Expand Down Expand Up @@ -212,9 +217,11 @@ function configurationMiddleware(params: ConfigurationParams): LSPAny[] | Respon

switch (configuration.get<"off" | "auto" | "extension" | "zls">("buildOnSaveProvider", "auto")) {
case "auto":
additionalOptions["buildOnSaveArgs"] = configuration.get("buildOnSaveArgs");
break;
case "zls":
additionalOptions["enableBuildOnSave"] = true;
additionalOptions["buildOnSaveArgs"] = configuration.get("buildOnSaveArgs");
break;
case "off":
case "extension":
Expand Down