Skip to content

refactor(vsock): more permissive binding for make public scope #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

refactor(vsock): more permissive binding for make public scope #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/devices/src/virtio/vsock/ip_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,8 @@ impl IpFilterConfig {
// Scope 1: Group - Allow binding within the subnet if no specific IP given
// If no subnet is specified, behaves like scope 0 (deny all)
1 => self.subnet.map_or(false, |subnet| subnet.contains(bind_ip)),
// Scope 2: Public - Allow binding to public IPs if no specific IP given
2 => !Self::is_private(bind_ip),
// Scope 3: Any - Allow binding to any IP if no specific IP given
3 => true,
// Scope 2 & 3: Any & Public - Allow binding to any IP if no specific IP given
2 | 3 => true,
_ => false, // Invalid scope (scope 0 already handled)
}
}
Expand Down